Skip to content

Avoid warnings in React >=16.3 #1409

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
wants to merge 1 commit into from
Closed

Avoid warnings in React >=16.3 #1409

wants to merge 1 commit into from

Conversation

samkline
Copy link

@samkline samkline commented Oct 1, 2019

Following up on #1407, there are two issues still causing warnings on the 5.x branch:

  • In development, componentWillUpdate is used. Even though this is dev-only, it causes verbose warnings that can mask other issues when working in a large project.
  • componentWillReceiveProps is incorrectly deleted from Connect's static properties, not from the prototype, so the delete is actually a no-op.

This PR addresses both issues. Thanks!

@samkline
Copy link
Author

samkline commented Oct 1, 2019

I just realized this caused some tests to fail, so I'll close this PR while I investigate it.

@samkline samkline closed this Oct 1, 2019
@samkline samkline mentioned this pull request Oct 1, 2019
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@samkline